Subject: Re: [PATCH] perf_events: fix validate_event bug
From: Peter Zijlstra <peterz@infradead.org>
To: eranian@gmail.com
Cc: Paul Mackerras <paulus@samba.org>, linux-kernel@vger.kernel.org,
       mingo@elte.hu, perfmon2-devel@lists.sf.net, eranian@google.com
In-Reply-To: <7c86c4470911242147u160008d4y50385cb348615df8@mail.gmail.com>
References: <1256223091-6002-1-git-send-email-eranian@gmail.com>
	 <1258562785.3918.685.camel@laptop>
	 <7c86c4470911230534i4119734k1478550567852220@mail.gmail.com>
	 <1258983953.4531.456.camel@laptop>
	 <7c86c4470911240518qe0c3e87k589437ef43f4a3d4@mail.gmail.com>
	 <19212.22371.633313.129961@cargo.ozlabs.ibm.com>
	 <7c86c4470911242147u160008d4y50385cb348615df8@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 25 Nov 2009 08:55:57 +0100
Message-ID: <1259135757.4027.5.camel@laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 727
Lines: 16

On Wed, 2009-11-25 at 06:47 +0100, stephane eranian wrote:
> It seems to me you have two ways of solving this:
>   1- push the algorithm to assign events to counters up in the generic code
>   2- have the generic code invoke all possible constraint sources on each group

2, is what it currently does. 

Since we can only add a single event to a group at a time, and we know
the previous group was schedulable, we only need to validate the
constraints on the pmu of the new event.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/