Date: Wed, 25 Nov 2009 17:00:32 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>, Alexey Dobriyan <adobriyan@gmail.com>,
       Ananth Mavinakayanahalli <ananth@in.ibm.com>,
       "Frank Ch. Eigler" <fche@redhat.com>,
       Peter Zijlstra <peterz@infradead.org>,
       Roland McGrath <roland@redhat.com>, linux-kernel@vger.kernel.org,
       utrace-devel@redhat.com
Subject: Re: [RFC,PATCH 14/14] utrace core
Message-ID: <20091125160032.GB9456@elte.hu>
References: <20091124200220.GA5828@redhat.com>
 <87my2bwtno.fsf@basil.nowhere.org>
 <20091124204152.GA9131@redhat.com>
 <20091124212619.GB29096@one.firstfloor.org>
 <20091124214450.GA12828@redhat.com>
 <20091125084617.GD29096@one.firstfloor.org>
 <20091125145556.GA5394@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091125145556.GA5394@redhat.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 906
Lines: 25


* Oleg Nesterov <oleg@redhat.com> wrote:

> Much better. But in this case please note that most of tracehooks just 
> do:
> 
> 		if (unlikely(task_utrace_flags(current) & SOME_EVENT))
> 			utrace_report_some_event();
> 
> I really don't understand why we shouldn't have (trivial!) helpers for 
> this. (As for naming - personally I do not care at all ;)

We prefer helpers in most such cases - especially when in the normal 
case the helper has no side effects - as here. Then we want to compress 
all such reporting/callback as much as possible.

Using helpers to abstract away functionality is one of the basic 
elements of writing clean kernel code.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/