Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759863AbZKYWpq (ORCPT ); Wed, 25 Nov 2009 17:45:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759865AbZKYWpp (ORCPT ); Wed, 25 Nov 2009 17:45:45 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33221 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759861AbZKYWpo (ORCPT ); Wed, 25 Nov 2009 17:45:44 -0500 Date: Thu, 26 Nov 2009 08:13:59 +1100 From: Neil Brown To: Jiri Slaby Cc: James Bottomley , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-scsi@vger.kernel.org, Jens Axboe Subject: Re: BUG at scsi_lib.c:1108 [Was: mmotm 2009-11-24-16-47 uploaded] Message-ID: <20091126081359.414c8216@notabene.brown> In-Reply-To: <4B0D9221.2050103@gmail.com> References: <200911250111.nAP1BFg5030254@imap1.linux-foundation.org> <4B0D4949.4090109@gmail.com> <1259162399.2535.8.camel@mulgrave.site> <4B0D9221.2050103@gmail.com> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 26 On Wed, 25 Nov 2009 21:22:57 +0100 Jiri Slaby wrote: > It doesn't make sense at all. How can empty merge cause a regression? > And md/for-next doesn't produce the BUG. I've hit that situation before. Two separate changes in separate branches conspire to cause a problem. md/for-next contains code to handle barriers properly for all levels, not just RAID1. It is possible I got this wrong in some way, and some new sanity check in a separate branch is firing, or it is possible some other bug in barrier handling has been added and now that MD sends barriers, it is being triggered. What I did to find the actual offending patches is to got to one of the heads just before the merge, and cherry-pick all the patches from the other branch, and then bisect that. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/