Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935104AbZKYVu3 (ORCPT ); Wed, 25 Nov 2009 16:50:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935073AbZKYVu3 (ORCPT ); Wed, 25 Nov 2009 16:50:29 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:39625 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934901AbZKYVu2 (ORCPT ); Wed, 25 Nov 2009 16:50:28 -0500 Date: Wed, 25 Nov 2009 16:50:18 -0500 From: Christoph Hellwig To: Andi Kleen Cc: Oleg Nesterov , Alexey Dobriyan , Ananth Mavinakayanahalli , Christoph Hellwig , "Frank Ch. Eigler" , Ingo@firstfloor.org, "Molnar References: <20091124200220.GA5828@redhat.com> <87my2bwtno.fsf@basil.nowhere.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87my2bwtno.fsf@basil.nowhere.org> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 27 On Tue, Nov 24, 2009 at 09:32:27PM +0100, Andi Kleen wrote: > Oleg Nesterov writes: > > > From: Roland McGrath > > > > This adds the utrace facility, a new modular interface in the kernel > > for implementing user thread tracing and debugging. This fits on top > > of the tracehook_* layer, so the new code is well-isolated. > > Could we just drop the tracehook layer if this finally merged > and call the low level functions directly? > > It might have been reasonably early on when it was still out of tree, > but longer term when it's integrated having strange opaque hooks > like that just makes the coder harder to read and maintain. I agree that linux/tracehook.h as a separate layer is pretty annoying, but a lot of the helper actually are quite useful. I'd suggest to throw a patch ontop of the series to rename all the useful macros to utrace_ and move them into utrace.h and just remove those that are really trivial wrappers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/