Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759268AbZKYXVg (ORCPT ); Wed, 25 Nov 2009 18:21:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758889AbZKYXVf (ORCPT ); Wed, 25 Nov 2009 18:21:35 -0500 Received: from rex.securecomputing.com ([203.24.151.4]:35243 "EHLO cyberguard.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758880AbZKYXVf (ORCPT ); Wed, 25 Nov 2009 18:21:35 -0500 Message-ID: <4B0DBC48.7000208@snapgear.com> Date: Thu, 26 Nov 2009 09:22:48 +1000 From: Greg Ungerer User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Mike Frysinger CC: uclinux-dev@uclinux.org, David Howells , David McCullough , Greg Ungerer , Paul Mundt , linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, Jie Zhang Subject: Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm() References: <1259128503-28276-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1259128503-28276-1-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1870 Lines: 48 Mike Frysinger wrote: > From: Jie Zhang > > The mmu code uses the copy_*_user_page() variants in access_process_vm() > rather than copy_*_user() as the former includes an icache flush. This is > important when doing things like setting software breakpoints with gdb. > So switch the nommu code over to do the same. > > Signed-off-by: Jie Zhang > Signed-off-by: Mike Frysinger Acked-by: Greg Ungerer > mm/nommu.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index 9876fa0..51ae9be 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -1889,9 +1889,11 @@ int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, in > > /* only read or write mappings where it is permitted */ > if (write && vma->vm_flags & VM_MAYWRITE) > - len -= copy_to_user((void *) addr, buf, len); > + copy_to_user_page(vma, NULL, NULL, > + (void *) addr, buf, len); > else if (!write && vma->vm_flags & VM_MAYREAD) > - len -= copy_from_user(buf, (void *) addr, len); > + copy_from_user_page(vma, NULL, NULL, > + buf, (void *) addr, len); > else > len = 0; > } else { -- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/