Date: Wed, 25 Nov 2009 17:30:19 -0800
From: Philip Langdale <philipl@overt.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Pierre Ossman <pierre@ossman.eu>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Port ricoh_mmc from driver to pci quirk.
Message-ID: <20091125173019.74d0ddb9@fido2.homeip.net>
In-Reply-To: <1259192401.15916.48.camel@maxim-laptop>
References: <1259021583.16650.9.camel@maxim-laptop>
	<20091123162119.3777e14d@fido2.homeip.net>
	<1259160947.10147.1.camel@maxim-laptop>
	<1259161121.10147.4.camel@maxim-laptop>
	<20091125085324.1ef9ae1f@fido2.homeip.net>
	<20091125113501.1f4d42b9.akpm@linux-foundation.org>
	<1259192401.15916.48.camel@maxim-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 27

On Thu, 26 Nov 2009 01:40:01 +0200
Maxim Levitsky <maximlevitsky@gmail.com> wrote:

 
> Of course, I can put that under config condition, that users that are
> sure that have no such device could save few hundreds of bytes.
> However a distro probably will enable this option.

Yeah, this is the only way I can think of to make it optional - and
i guess we could actually reuse the current CONFIG value to make it
transparent. I kind of like this, but there's no precedent for it
in PCI quirks as far as I can tell.
 
> I also agree that I need to print some notice to user about device
> being disabled.
> 
> Aside from being almost an 1:1 copy of original driver, this patch was
> sort of RFC, so I update it soon.

Thanks!

--phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/