Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759069AbZKZHqn (ORCPT ); Thu, 26 Nov 2009 02:46:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759014AbZKZHqm (ORCPT ); Thu, 26 Nov 2009 02:46:42 -0500 Received: from out4.smtp.messagingengine.com ([66.111.4.28]:32878 "EHLO out4.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbZKZHqm (ORCPT ); Thu, 26 Nov 2009 02:46:42 -0500 X-Sasl-enc: gyfd5L9fLcyXdeP6Aiuj9b6eJ8aVfk55ehaFdkHKvkCO 1259221598 Message-ID: <4B0E325B.7060203@ladisch.de> Date: Thu, 26 Nov 2009 08:46:35 +0100 From: Clemens Ladisch User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Andrew Morton CC: Jean Delvare , Serge Belyshev , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, x86@kernel.org Subject: Re: [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11h CPUs References: <4AF91F70.10106@ladisch.de> <4B06501B.8080509@ladisch.de> <87ws1l5wcl.fsf@depni.sinp.msu.ru> <4B0673D7.5010006@ladisch.de> <20091120123016.19d98ab4@hyperion.delvare> <4B068402.7020606@ladisch.de> <20091120131855.7f8f8722@hyperion.delvare> <4B0A3DB6.9090703@ladisch.de> <20091123145154.5b2b5735@hyperion.delvare> <4B0AAA55.3040702@ladisch.de> <20091123200527.1114cbc2@hyperion.delvare> <4B0B9CBB.2050107@ladisch.de> <20091125114544.df69cc98.akpm@linux-foundation.org> In-Reply-To: <20091125114544.df69cc98.akpm@linux-foundation.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 35 Andrew Morton wrote: > Clemens Ladisch wrote: > > This adds a driver for the internal temperature sensor of AMD Family 10h > > and 11h CPUs. > > ... > > +#define REG_HARDWARE_THERMAL_CONTROL 0x64 > > +#define HTC_ENABLE 0x00000001 > > + > > +#define REG_REPORTED_TEMPERATURE 0xa4 > > + > > +#define REG_NORTHBRIDGE_CAPABILITIES 0xe8 > > +#define NB_CAP_HTC 0x00000400 > > These definitions relate to register addresses within the AMD CPUs, > yes? Yes, in the PCI configuration space of the internal northbridge. > I wonder if these should be placed in some header file in > arch/x86/include/asm/ where other such things are described. There is no such header. The files that also access PCI cfg registers: arch/x86/kernel/k8.c arch/x86/kernel/quirks.c arch/x86/oprofile/op_model_amd.c define their own private symbols or use magic numbers. Best regards, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/