Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759227AbZKZIgR (ORCPT ); Thu, 26 Nov 2009 03:36:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752753AbZKZIgQ (ORCPT ); Thu, 26 Nov 2009 03:36:16 -0500 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:56075 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbZKZIgQ (ORCPT ); Thu, 26 Nov 2009 03:36:16 -0500 Date: Thu, 26 Nov 2009 09:36:21 +0100 From: Jens Axboe To: Li Zefan Cc: Ingo Molnar , Steven Rostedt , Frederic Weisbecker , LKML Subject: Re: [PATCH 6/9] tracing: Convert some block events to DEFINE_EVENT Message-ID: <20091126083621.GM8742@kernel.dk> References: <4B0E2807.4060102@cn.fujitsu.com> <4B0E28E6.7060609@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B0E28E6.7060609@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 20 On Thu, Nov 26 2009, Li Zefan wrote: > use TRACE_EVENT_TEMPLATE to remove duplicate code: > > text data bss dec hex filename > 53570 3284 184 57038 dece block/blk-core.o.old > 43702 3284 144 47130 b81a block/blk-core.o Nice! When I played with the writeback tracing, I did notice that code bloat does get pretty severe quickly. I have applied this to for-2.6.33, thanks a lot. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/