Date: Thu, 26 Nov 2009 10:03:53 +0100
From: Jens Axboe <jens.axboe@oracle.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
       Jeff Moyer <jmoyer@redhat.com>, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 0/4] cfq-iosched: policy fixes
Message-ID: <20091126090353.GR8742@kernel.dk>
References: <200911241448.29871.czoccolo@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200911241448.29871.czoccolo@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1250
Lines: 27

On Tue, Nov 24 2009, Corrado Zoccolo wrote:
> Hi Jens,
> I've collected some bugfixes to the for-2.6.33 branch.
> Excluding the NCQ policy fix, that I'm resending with improved changelog,
> the bugs were found by Vivek while investingating performance drops
> or unfairness while testing cgroups. Nevertheless, those fixes have
> general impact, so they should go in before cgroup code is merged:
> * no-idle preemption logic was both under/over preempting.
>    it should preempt only if the active queue is idling due to
>    no-idle service tree empty
> * seeky queues with large depth could steal too much bandwidth to
>    low depth ones, so they will be marked as idling, and have exclusive
>    access to disk for their time share
> * the idling logic had some corner cases in which idling was not enabled,
>   even if it should have been, caused by rq_noidle and rq_in_driver checks.
>   Those were adjusted to better match the original intention.

Thanks Corrado, applied all 4!

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/