Subject: Re: [PATCH RFC] Codingstyle: allow omitting braces for all single
 statement branches
From: Peter Zijlstra <peterz@infradead.org>
To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
       Randy Dunlap <rdunlap@xenotime.net>, Teemu Likonen <tlikonen@iki.fi>,
       Jiri Kosina <jkosina@suse.cz>, Dan Carpenter <error27@gmail.com>,
       Martin Olsson <martin@minimum.se>, linux-doc@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>
In-Reply-To: <1259227618-1466-1-git-send-email-u.kleine-koenig@pengutronix.de>
References: <1259227618-1466-1-git-send-email-u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 26 Nov 2009 15:52:59 +0100
Message-ID: <1259247179.31676.112.camel@laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 968
Lines: 39

On Thu, 2009-11-26 at 10:26 +0100, Uwe Kleine-König wrote:

> -This does not apply if one branch of a conditional statement is a single
> -statement. Use braces in both branches.
> -
> -if (condition) {
> -	do_this();
> -	do_that();
> -} else {
> -	otherwise();
> -}
> +If not all branches of a conditional statement are single statements you might
> +use braces for both branches.
> +
> +	if (condition) {
> +		do_this();
> +		do_that();
> +	} else
> +		otherwise();
> +
> +or
> +
> +	if (condition) {
> +		do_this();
> +		do_that();
> +	} else {
> +		otherwise();
> +	}
>  
>  		3.1:  Spaces

Andrew recently objected to this pattern, and I tend to agree with him
although I might be guilty of a few such cases myself.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/