Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759828AbZKZQoN (ORCPT ); Thu, 26 Nov 2009 11:44:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755558AbZKZQoM (ORCPT ); Thu, 26 Nov 2009 11:44:12 -0500 Received: from one.firstfloor.org ([213.235.205.2]:58764 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758555AbZKZQoL (ORCPT ); Thu, 26 Nov 2009 11:44:11 -0500 Date: Thu, 26 Nov 2009 17:44:14 +0100 From: Andi Kleen To: Stefani Seibold Cc: Andrew Morton , linux-kernel , Arnd Bergmann , Andi Kleen , Amerigo Wang , Joe Perches , Roger Quadros , Greg Kroah-Hartman , Mauro Carvalho Chehab Subject: Re: [PATCH 7/7] kfifo: add record handling functions Message-ID: <20091126164414.GK29096@one.firstfloor.org> References: <1258704942.4426.5.camel@wall-e> <1258705988.4426.22.camel@wall-e> <20091123141914.e320c341.akpm@linux-foundation.org> <1259251632.26705.17.camel@wall-e> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1259251632.26705.17.camel@wall-e> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 25 On Thu, Nov 26, 2009 at 05:07:12PM +0100, Stefani Seibold wrote: > I analyzed the code and most of them will be optimized away by the > compiler. The reason for this design decision was that i want no > performance regression against the old kfifo implementation. > > But if the majority vote for an non inline version i will do it. It will > make the code more readable and slim down the footprint. I vote for smaller text size if possible. I doubt kfifo is used in any circumstances where a function call or two is a big problem. But of course some inlines might be smaller than calls. But then this code has been pending for a long time and I have some potential users. It would be good to merge ASAP and do such tweaks later in tree. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/