Message-ID: <4B0EB986.2010801@ru.mvista.com>
Date: Thu, 26 Nov 2009 20:23:18 +0300
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Organization: MontaVista Software Inc.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
MIME-Version: 1.0
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_it8213: MWDMA0 is unsupported
References: <200911261728.36433.bzolnier@gmail.com> <200911261800.55025.bzolnier@gmail.com>
In-Reply-To: <200911261800.55025.bzolnier@gmail.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1094
Lines: 36

Bartlomiej Zolnierkiewicz wrote:

>>MWDMA0 timings cannot be met with the PIIX based controller
>>programming interface.

>>This change should be safe as this is how we have been doing
>>things in IDE it8213 host driver for years.

>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>---
>>Verified with the documentation (similar case as with pata_efar).

> Uhhh, no...

> Too many damn drivers.

> Too much damn duplication.

> Too much damn subtle differences here and there.

> The hardware is probably fine for MWMDA0 when it comes to pata_{efar,it8213},
> it just not documented properly in the data sheet.

    How so with pata_efar? The active/recovery bitfields are still 2-bit 
wide, no?

> I'll drop those two patches from my tree and take some break..

    Taking a break is good, not sure about dropping yet.

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/