Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751151AbZKZSLy (ORCPT ); Thu, 26 Nov 2009 13:11:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750932AbZKZSLx (ORCPT ); Thu, 26 Nov 2009 13:11:53 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:48689 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbZKZSLw (ORCPT ); Thu, 26 Nov 2009 13:11:52 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:message-id:content-type:content-transfer-encoding; b=UoOjYRg/tuILwArUvhOe1Lp1Cu30xtW1vkwquIJwZTviiwRkTRFJgSW0USCAB8wKRD fn1e3lxzGsKECnG3R2wQ/ojI+Q46yrbeZopUpONJcJabXuXMqO3qqyixkZJIEGS2KnnO 2cLadAYFtIRP6LaeRHXQ9K6xtsvEibCqHrlak= From: Bartlomiej Zolnierkiewicz To: Sergei Shtylyov , Alan Cox Subject: Re: [PATCH] pata_it8213: MWDMA0 is unsupported Date: Thu, 26 Nov 2009 19:03:01 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.31.5-0.1-desktop; KDE/4.3.1; x86_64; ; ) Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <200911261728.36433.bzolnier@gmail.com> <4B0EB986.2010801@ru.mvista.com> <200911261900.11506.bzolnier@gmail.com> In-Reply-To: <200911261900.11506.bzolnier@gmail.com> MIME-Version: 1.0 Message-Id: <200911261903.01199.bzolnier@gmail.com> Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 42 On Thursday 26 November 2009 07:00:11 pm Bartlomiej Zolnierkiewicz wrote: > On Thursday 26 November 2009 06:23:18 pm Sergei Shtylyov wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > > >>MWDMA0 timings cannot be met with the PIIX based controller > > >>programming interface. > > > > >>This change should be safe as this is how we have been doing > > >>things in IDE it8213 host driver for years. > > > > >>Signed-off-by: Bartlomiej Zolnierkiewicz > > >>--- > > >>Verified with the documentation (similar case as with pata_efar). > > > > > Uhhh, no... > > > > > Too many damn drivers. > > > > > Too much damn duplication. > > > > > Too much damn subtle differences here and there. > > > > > The hardware is probably fine for MWMDA0 when it comes to pata_{efar,it8213}, > > > it just not documented properly in the data sheet. > > > > How so with pata_efar? The active/recovery bitfields are still 2-bit > > wide, no? > > Yes but when TIMEx bit is disabled we are using XFER_PIO_SLOW timings. > > All data sheets including original Intel ones are a complete crap when it > comes to explicitly documenting this behavior. OTOH all drivers set TIMEx for MWDMA0 currently.. ? -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/