Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752719AbZKZV1G (ORCPT ); Thu, 26 Nov 2009 16:27:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752290AbZKZV1G (ORCPT ); Thu, 26 Nov 2009 16:27:06 -0500 Received: from khc.piap.pl ([195.187.100.11]:40619 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbZKZV1E (ORCPT ); Thu, 26 Nov 2009 16:27:04 -0500 From: Krzysztof Halasa To: Mauro Carvalho Chehab Cc: Jarod Wilson , Dmitry Torokhov , linux-kernel@vger.kernel.org, Mario Limonciello , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Janne Grunau , Christoph Bartelmus Subject: Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure References: <200910200956.33391.jarod@redhat.com> <200910200958.50574.jarod@redhat.com> <4B0A765F.7010204@redhat.com> <4B0A81BF.4090203@redhat.com> <4B0AC65C.806@redhat.com> <4B0E765C.2080806@redhat.com> <4B0ED238.6060306@redhat.com> <4B0EED7D.90204@redhat.com> Date: Thu, 26 Nov 2009 22:27:08 +0100 In-Reply-To: <4B0EED7D.90204@redhat.com> (Mauro Carvalho Chehab's message of "Thu, 26 Nov 2009 19:05:01 -0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 31 Mauro Carvalho Chehab writes: > No. All the other API functions there work with 32 bits for scancodes. We don't need them, do we? We need a new ioctl for changing key mappings anyway (a single ioctl for setting the whole table I think), and we can have arbitrary length of scan codes there. > (what's worse is that it is defined as "int" instead of "u32" - so the number > of bits is different on 32 and on 64 systems) Most (all?) 64-bit systems use 32-bit ints (and 64-bit longs). u32 and similar are for sure better. >> We signal both and hope it isn't self-destruct button. >> We can't fix it no matter how hard we try. > > We can fix. Just let the userspace select what protocol(s) is(are) enabled. Sure, I meant the situation when both protocols (and scan codes) where enabled and configured. If we don't use RCx in the mapping table, we don't pass anything to RCx routine. If we have RCx but don't have the scan code in question, we don't find the key in the table and thus we ignore it again. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/