Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576AbZK0LgZ (ORCPT ); Fri, 27 Nov 2009 06:36:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754527AbZK0LgX (ORCPT ); Fri, 27 Nov 2009 06:36:23 -0500 Received: from mga03.intel.com ([143.182.124.21]:23832 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475AbZK0LgU (ORCPT ); Fri, 27 Nov 2009 06:36:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.47,300,1257148800"; d="scan'208";a="216271224" Message-Id: <20091127110407.852540101@intel.com> User-Agent: quilt/0.48-1 Date: Fri, 27 Nov 2009 18:59:13 +0800 From: Wu Fengguang To: Andrew Morton To: Jens Axboe Cc: Wu Fengguang , LKML cc: Subject: [PATCH 5/6] writeback: remove the always false bdi_cap_writeback_dirty() test References: <20091127105908.944744141@intel.com> Content-Disposition: inline; filename=writeback-remove-memory-bdi.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1521 Lines: 50 This is dead code because no bdi flush thread will be started for !bdi_cap_writeback_dirty bdi. CC: Jens Axboe Signed-off-by: Wu Fengguang --- fs/fs-writeback.c | 18 ------------------ 1 file changed, 18 deletions(-) --- linux.orig/fs/fs-writeback.c 2009-11-27 18:54:50.000000000 +0800 +++ linux/fs/fs-writeback.c 2009-11-27 18:55:11.000000000 +0800 @@ -614,7 +614,6 @@ static void writeback_inodes_wb(struct b struct writeback_control *wbc) { struct super_block *sb = wbc->sb, *pin_sb = NULL; - const int is_blkdev_sb = sb_is_blkdev_sb(sb); const unsigned long start = jiffies; /* livelock avoidance */ spin_lock(&inode_lock); @@ -635,23 +634,6 @@ static void writeback_inodes_wb(struct b continue; } - if (!bdi_cap_writeback_dirty(wb->bdi)) { - redirty_tail(inode); - if (is_blkdev_sb) { - /* - * Dirty memory-backed blockdev: the ramdisk - * driver does this. Skip just this inode - */ - continue; - } - /* - * Dirty memory-backed inode against a filesystem other - * than the kernel-internal bdev filesystem. Skip the - * entire superblock. - */ - break; - } - if (inode->i_state & (I_NEW | I_WILL_FREE)) { requeue_io(inode); continue; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/