Message-ID: <4B0FD0B2.9070303@chelcom.ru>
Date: Fri, 27 Nov 2009 18:14:26 +0500
From: "A. Porodko" <panda@chelcom.ru>
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706)
MIME-Version: 1.0
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
CC: Chaithrika U S <chaithrika@ti.com>,
       "'Liam Girdwood'" <lrg@slimlogic.co.uk>,
       "'Jaroslav Kysela'" <perex@perex.cz>, "'Takashi Iwai'" <tiwai@suse.de>,
       "'Troy Kisky'" <troy.kisky@boundarydevices.com>,
       "'David Brownell'" <dbrownell@users.sourceforge.net>,
       "'Kevin Hilman'" <khilman@deeprootsystems.com>,
       alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] Sound support for Neuros OSD2 Davinci based board.
References: <4B0E7D5E.3080906@chelcom.ru> <002e01ca6e9c$2dab6040$890220c0$@com> <20091127111254.GB29512@sirena.org.uk>
In-Reply-To: <20091127111254.GB29512@sirena.org.uk>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1239
Lines: 43

Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:57:19PM +0530, Chaithrika U S wrote:
>
>   
>> @@ -246,6 +249,9 @@ static int __init evm_init(void)
>>  	if (machine_is_davinci_evm()) {
>>  		evm_snd_dev_data = &evm_snd_devdata;
>>  		index = 0;
>> +	} else if (machine_is_neuros_osd2()) {
>> +		evm_snd_dev_data = &evm_snd_devdata;
>> +		index = 0;
>>     
>
>   
>> The above can be combined with the check for DaVinci EVM
>> 	if (machine_is_davinci_evm() ||
>> 				(machine_is_neuros_osd2()) {
>>  		evm_snd_dev_data = &evm_snd_devdata;
>>  		index = 0;
>>     
>
> I raised the same query when Andrey sent an off-list copy to me by
> mistake - he said that in future he intends to extend the driver to 
> have additional features not present on the EVM (though for me that
> could always change the || later).
>
> Andrey, with Linux kernel patches reply to all is generally the way
> forward.
>   
Mark,

Understood. Shall I change if if to if || then?

-- 
Best regards
Andrey A. Porodko
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/