From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 0/3] macvlan: support for guest vm direct rx/tx
Date: Sat, 28 Nov 2009 00:43:58 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; x86_64; ; )
Cc: Patrick Mullaney <pmullaney@novell.com>, kaber@trash.net,
       netdev@vger.kernel.org, alacrityvm-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
References: <4AFAD86A.9070506@trash.net> <20091113195201.11184.25766.stgit@mimic.site> <20091113132728.0f1db7c5@s6510>
In-Reply-To: <20091113132728.0f1db7c5@s6510>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200911280043.58784.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 691
Lines: 18

On Friday 13 November 2009, Stephen Hemminger wrote:
> Also, macvlan should really being calling netif_receive_skb()
> not going through another queue/softirq cycle.

I've added a patch for this in my experimental queue now.
When I last tried this, I saw a kernel stack overflow
but it seems fine now.

I wonder if we can also return from the macvlan hook with
skb->dev changed to netif_receive_skb rather than calling it
recursively.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/