Message-ID: <4B10741C.9090305@collabora.co.uk>
Date: Sat, 28 Nov 2009 00:51:40 +0000
From: Ian Molton <ian.molton@collabora.co.uk>
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707)
MIME-Version: 1.0
To: Matt Mackall <mpm@selenic.com>
CC: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, jeff@garzik.org,
       Herbert Xu <herbert@gondor.apana.org.au>
Subject: rng updates
References: <1259197403.2858.88.camel@calx>	 <1259232570-11918-1-git-send-email-ian.molton@collabora.co.uk>	 <1259235525.9212.444.camel@calx>  <4B0E6B02.8020705@collabora.co.uk> <1259362496.25403.165.camel@calx>
In-Reply-To: <1259362496.25403.165.camel@calx>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1376
Lines: 36

Matt Mackall wrote:
> On Thu, 2009-11-26 at 11:48 +0000, Ian Molton wrote:
>> Matt Mackall wrote:
>>> On Thu, 2009-11-26 at 10:49 +0000, Ian Molton wrote:
>>>> Hi guys,
>>>>
>>> No need to pass rng_buffer to the helper as there's only one with global
>>> scope.
>> Ah, sorry, I see what you mean now. The logic behind that is that it
>> matches the new API, whcih is all that will be left once the old drivers
>> are patched to use it. I planned to drop the helper altogether at that
>> point and though it'd make the patch more readable when that happens.
> 
> Ok, that's quite reasonable.
> 
>> Is this enough to get an acked-by: ? If so, I'll do that and see about
>> getting the change into linux-next.
> 
> Acked-by: Matt Mackall <mpm@selenic.com>

Just to check - is that with or without changing the helpers parameters?

> You should probably go through Herbert's tree to get into -next,
> hopefully he won't be too miffed by your repeated failure to cc:
> linux-kernel initially and failure to cc: him here..

Drat, I thought he'd been re-added when LKML got added to the CC: list.
Sorry about that. Re-added to CC:

-Ian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/