Date: Sat, 28 Nov 2009 08:28:39 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Jiri Slaby <jslaby@suse.cz>, nhorman@tuxdriver.com, sfr@canb.auug.org.au,
       linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       marcin.slusarz@gmail.com, tglx@linutronix.de, mingo@redhat.com,
       hpa@zytor.com, torvalds@linux-foundation.org, oleg@redhat.com,
       Stephen Smalley <sds@tycho.nsa.gov>, Eric Paris <eparis@parisplace.org>,
       David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v3 00/27] writable limits
Message-ID: <20091128072839.GA6689@elte.hu>
References: <1259363167-9347-1-git-send-email-jslaby@suse.cz>
 <4B1063A7.2030206@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B1063A7.2030206@gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 46


* Jiri Slaby <jirislaby@gmail.com> wrote:

> Hi,
> 
> I broke the threading to not mess up with the long thread.
> 
> In this version I got rid of the rlim access_only ugliness.

Thanks Jiri - this series looks very clean already and the helpers make 
the various usage sites easier to understand as well.

One (very small) naming suggestion, please rename:

 rlim_get_cur()
 rlim_get_max()
 task_rlim_get_cur()
 task_rlim_get_max()

To a more natural sounding scheme like:

 rlimit()
 rlimit_max()
 task_rlimit()
 task_rlimit_max()

Reasons:

 - 'cur' is a misnomer that came a decade+ ago from an ABI and there's 
   no need to continue that bad tradition in helper functions. It can 
   also be confused with 'curr' which we often use for the current task.

 - 'rlimit' is general meme, plus there's no need to say it out aloud 
   that we 'get' it - rlimit() is obvious enough.

Beyond solving these issues it makes it shorter and more logical as 
well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/