Subject: Re: [PATCH] leds: fix the return value of ich7_lpc_probe.
From: Dave Hansen <dave@sr71.net>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, rpurdie@rpsys.net, martinez.javier@gmail.com
In-Reply-To: <1259423290-6864-1-git-send-email-tfransosi@gmail.com>
References: <1259423290-6864-1-git-send-email-tfransosi@gmail.com>
Content-Type: text/plain
Date: Sat, 28 Nov 2009 11:47:45 -0800
Message-Id: <1259437665.10954.775.camel@nimitz>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1269
Lines: 35

On Sat, 2009-11-28 at 10:48 -0500, Thiago Farina wrote:
> In the function ich7_lpc_probe there is a 'return' that is not returning any
> value, but it should because the return type is int not void.
> 
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
>  drivers/leds/leds-ss4200.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
> index c7f6347..a0c4092 100644
> --- a/drivers/leds/leds-ss4200.c
> +++ b/drivers/leds/leds-ss4200.c
> @@ -350,7 +350,7 @@ static int __devinit ich7_lpc_probe(struct pci_dev *dev,
>  	status = pci_enable_device(dev);
>  	if (status) {
>  		dev_err(&dev->dev, "pci_enable_device failed\n");
> -		return;
> +		return status;
>  	}

There's a patch in -mm to do something similar.  It should be pushed
upstream when the next set of -mm patches goes.

http://userweb.kernel.org/~akpm/mmotm/broken-out/drivers-leds-leds-ss4200c-fix-return-statement.patch

Thanks for posting this, though.  

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/