Date: Sun, 29 Nov 2009 09:17:26 -0800
From: Greg KH <greg@kroah.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
       linux-input@vger.kernel.org
Subject: Re: [IR-RFC PATCH v4 2/6] Core IR module
Message-ID: <20091129171726.GB4993@kroah.com>
References: <20091127013217.7671.32355.stgit@terra> <20091127013423.7671.36546.stgit@terra>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091127013423.7671.36546.stgit@terra>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1807
Lines: 65

> +static ssize_t ir_raw_show(struct device *dev,
> +				 struct device_attribute *attr, char *buf)
> +{
> +	struct input_dev *input_dev = to_input_dev(dev);
> +	unsigned int i, count = 0;
> +
> +	for (i = input_dev->ir->raw.tail; i != input_dev->ir->raw.head; ) {
> +
> +		count += snprintf(&buf[count], PAGE_SIZE - 1, "%i\n", input_dev->ir->raw.buffer[i++]);
> +		if (i > ARRAY_SIZE(input_dev->ir->raw.buffer))
> +			i = 0;
> +		if (count >= PAGE_SIZE - 1) {
> +			input_dev->ir->raw.tail = i;
> +			return PAGE_SIZE - 1;
> +		}
> +	}
> +	input_dev->ir->raw.tail = i;
> +	return count;
> +}

This looks like it violates the "one value per sysfs file" rule that we
have.  What exactly are you outputting here?  It does not look like this
belongs in sysfs at all.

> +static ssize_t ir_raw_store(struct device *dev,
> +				  struct device_attribute *attr,
> +				  const char *buf,
> +				  size_t count)
> +{
> +	struct ir_device *ir = to_input_dev(dev)->ir;
> +	long delta;
> +	int i = count;
> +	int first = 0;
> +
> +	if (!ir->xmit)
> +		return count;
> +	ir->send.count = 0;
> +
> +	while (i > 0) {
> +		i -= strict_strtoul(&buf[i], i, &delta);
> +		while ((buf[i] != '\n') && (i > 0))
> +			i--;
> +		i--;
> +		/* skip leading zeros */
> +		if ((delta > 0) && !first)
> +			continue;
> +
> +		ir->send.buffer[ir->send.count++] = abs(delta);
> +	}
> +
> +	ir->xmit(ir->private, ir->send.buffer, ir->send.count, ir->raw.carrier, ir->raw.xmitter);
> +
> +	return count;
> +}

What type of data are you expecting here?  More than one value?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/