Message-ID: <4B13396E.508@analog.com>
Date: Mon, 30 Nov 2009 11:18:06 +0800
From: Jie Zhang <jie.zhang@analog.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091125 Shredder/3.0
MIME-Version: 1.0
To: Mike Frysinger <vapier.adi@gmail.com>
CC: David Howells <dhowells@redhat.com>, Paul Mundt <lethal@linux-sh.org>,
       Bernd Schmidt <bernds_cb1@t-online.de>,
       Linux kernel mailing list <linux-kernel@vger.kernel.org>,
       uclinux-dist-devel <uclinux-dist-devel@blackfin.uclinux.org>
Subject: Re: avoiding duplicate icache flushing of shared maps on nommu
References: <8bd0f97a0911280740p24ad49bal64b924a427abfa39@mail.gmail.com>
In-Reply-To: <8bd0f97a0911280740p24ad49bal64b924a427abfa39@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1642
Lines: 49

On 11/28/2009 11:40 PM, Mike Frysinger wrote:
> when working with FDPIC, there are many shared maps of read only text
> regions (the C library, applet packages like busybox, ...) between
> applications.  but the current mm/nommu.c:do_mmap_pgoff() function
> will issue an icache flush whenever a vma is added to a mm instead of
> only doing it when the map is initially created.  am i missing
> something obvious here, or would a change like below be OK ?  this
> easily cuts the number of icache flushes during boot by 50% if not
> more.
>
> (yes, this now does the icache flush while holding the
> nommu_region_sem, but i'm interested if the _idea_ is OK)
>
I don't see any problem. But I'm not a kernel expert. I tried to take a 
look at the source code history. But I cannot find code older than 
2.6.12. In the CVS repository of uClinux, there is no similar code in 
kernel sub-directory. :-(


Jie


> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -1409,14 +1409,14 @@ unsigned long do_mmap_pgoff(struct file *file,
>
>      current->mm->total_vm += len>>  PAGE_SHIFT;
>
> +   if (prot&  PROT_EXEC)
> +       flush_icache_range(result, result + len);
> +
>   share:
>      add_vma_to_mm(current->mm, vma);
>
>      up_write(&nommu_region_sem);
>
> -   if (prot&  PROT_EXEC)
> -       flush_icache_range(result, result + len);
> -
>      kleave(" = %lx", result);
>      return result;
>
> -mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/