Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbZK3IER (ORCPT ); Mon, 30 Nov 2009 03:04:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752483AbZK3IEQ (ORCPT ); Mon, 30 Nov 2009 03:04:16 -0500 Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:32843 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbZK3IEP (ORCPT ); Mon, 30 Nov 2009 03:04:15 -0500 Date: Mon, 30 Nov 2009 02:57:30 -0500 Message-Id: <200911300757.nAU7vU73022810@agora.fsl.cs.sunysb.edu> From: Erez Zadok To: Valerie Aurora Cc: Jan Blunck , Alexander Viro , Christoph Hellwig , Andy Whitcroft , Scott James Remnant , Sandu Popa Marius , Jan Rekorajski , "J. R. Okajima" , Arnd Bergmann , Vladimir Dronnikov , Felix Fietkau , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Blunck Subject: Re: [PATCH 17/41] whiteout: Add path_whiteout() helper In-reply-to: Your message of "Wed, 21 Oct 2009 12:19:15 PDT." <1256152779-10054-18-git-send-email-vaurora@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1800 Lines: 47 In message <1256152779-10054-18-git-send-email-vaurora@redhat.com>, Valerie Aurora writes: > From: Jan Blunck > > Add a path_whiteout() helper for vfs_whiteout(). > > Signed-off-by: Jan Blunck > Signed-off-by: Valerie Aurora > --- > fs/namei.c | 15 ++++++++++++++- > include/linux/fs.h | 1 - > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index 9a62c75..408380d 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -2231,7 +2231,7 @@ static inline int may_whiteout(struct inode *dir, struct dentry *victim, > * After this returns with success, don't make any assumptions about the inode. > * Just dput() it dentry. > */ > -int vfs_whiteout(struct inode *dir, struct dentry *dentry, int isdir) > +static int vfs_whiteout(struct inode *dir, struct dentry *dentry, int isdir) Didn't some other patch introduce vfs_whiteout? So why have a second patch which makes vfs_whiteout a static? Why not introduce both vfs_whiteout and path_whiteout in one patch? > { > int err; > struct inode *old_inode = dentry->d_inode; > @@ -2283,6 +2283,19 @@ int vfs_whiteout(struct inode *dir, struct dentry *dentry, int isdir) > return err; > } > > +int path_whiteout(struct path *dir_path, struct dentry *dentry, int isdir) Please document the behavior of path_whiteout in a proper comment above ii (kernel-doc). Describe return values, side effects, etc. Also, isdir in both vfs_whiteout and path_whiteout can be boolean. Erez. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/