Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbZK3JNJ (ORCPT ); Mon, 30 Nov 2009 04:13:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752894AbZK3JNI (ORCPT ); Mon, 30 Nov 2009 04:13:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26519 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbZK3JNI (ORCPT ); Mon, 30 Nov 2009 04:13:08 -0500 Date: Mon, 30 Nov 2009 04:12:02 -0500 From: Amerigo Wang To: linux-kernel@vger.kernel.org Cc: Tejun Heo , akpm@linux-foundation.org, Amerigo Wang Message-Id: <20091130091501.4507.28683.sendpatchset@localhost.localdomain> Subject: [Patch] percpu: remove two suspicious break statements Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 33 These two break statements seem to be very suspicious, they are at the end of the statements inside the loop. Remove them. Signed-off-by: WANG Cong Cc: Tejun Heo --- diff --git a/mm/percpu.c b/mm/percpu.c index 5adfc26..dbcfee8 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -917,7 +917,6 @@ static void pcpu_depopulate_chunk(struct pcpu_chunk *chunk, int off, int size) pcpu_for_each_unpop_region(chunk, rs, re, page_start, page_end) { if (rs == page_start && re == page_end) return; - break; } /* immutable chunks can't be depopulated */ @@ -972,7 +971,6 @@ static int pcpu_populate_chunk(struct pcpu_chunk *chunk, int off, int size) pcpu_for_each_pop_region(chunk, rs, re, page_start, page_end) { if (rs == page_start && re == page_end) goto clear; - break; } /* need to allocate and map pages, this chunk can't be immutable */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/