Message-ID: <4B13A7ED.9010905@kernel.org>
Date: Mon, 30 Nov 2009 20:09:33 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090915 SUSE/3.0b4-3.6 Thunderbird/3.0b4
MIME-Version: 1.0
To: Amerigo Wang <amwang@redhat.com>
CC: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [Patch] percpu: remove two suspicious break statements
References: <20091130091501.4507.28683.sendpatchset@localhost.localdomain>
In-Reply-To: <20091130091501.4507.28683.sendpatchset@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 873
Lines: 26

On 11/30/2009 06:12 PM, Amerigo Wang wrote:
> These two break statements seem to be very suspicious,
> they are at the end of the statements inside the loop.
> Remove them.
> 
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: Tejun Heo <tj@kernel.org>

That actually is correct code.  It's checking whether the first
iteration covers the whole thing.  I thought the comment there

  /* quick path, check whether all pages are already there */

explained it but looking at it again, it definitely isn't enough
unless you already know what's going on there.  Can you please post a
patch to add the comment?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/