Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbZK3PdG (ORCPT ); Mon, 30 Nov 2009 10:33:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752280AbZK3PdC (ORCPT ); Mon, 30 Nov 2009 10:33:02 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:42621 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752107AbZK3PdB (ORCPT ); Mon, 30 Nov 2009 10:33:01 -0500 Date: Mon, 30 Nov 2009 15:32:23 +0000 From: Alan Cox To: Russell King - ARM Linux Cc: Thomas Gleixner , Rusty Russell , David Brownell , Eric Miao , Andrea Gallo , Peter Zijlstra , John Stultz , Nicolas Pitre , Jamie Lokier , LKML , Remy Bohmer , Hugh Dickins , Benjamin Herrenschmidt , Uwe =?ISO-8859-14?B?S2xlaW5lLUv2bmln?= , Andrew Morton , Linus Torvalds , Ingo Molnar , linux-arm-kernel@lists.infradead.org Subject: Re: Get rid of IRQF_DISABLED - (was [PATCH] genirq: warn about IRQF_SHARED|IRQF_DISABLED) Message-ID: <20091130153223.0e510a9b@lxorguk.ukuu.org.uk> In-Reply-To: <20091130150100.GB7028@n2100.arm.linux.org.uk> References: <1259356206-14843-1-git-send-email-u.kleine-koenig@pengutronix.de> <1259578067-29169-1-git-send-email-u.kleine-koenig@pengutronix.de> <1259589780.26472.18.camel@laptop> <20091130144702.14bea0ee@lxorguk.ukuu.org.uk> <20091130150100.GB7028@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 25 On Mon, 30 Nov 2009 15:01:00 +0000 Russell King - ARM Linux wrote: > On Mon, Nov 30, 2009 at 02:47:02PM +0000, Alan Cox wrote: > > SHARED|DISABLED ought to WARN_ON() and if that doesn't motivate people > > then return -EINVAL. > > That is an impossibility. There is hardware out there (AT91) where > the timer interrupt is shared with other peripherals, and you end > up with a mixture of irqs-disabled and irqs-enabled handlers sharing > the same interrupt. Well that will encourage people to fix it. > My point is that if we outlaw irqs-disabled shared interrupts, it puts > Atmel AT91 support into immediate difficulties. If a driver disables the timer irq across a tick aren't you already in trouble ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/