DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=ZhlGrmUuZjCzWW3yaZGOUu1eWcgHFAIbDdre0Jl2g9epfjN1heRdAbl54OUROXZNybUynGJVg+EiQTA7a6RDBUJSh6d+ClfYZR6CQEbY51pWGtPWt9zJv6j4wBsVbHAn;
Date: Mon, 30 Nov 2009 08:11:47 -0800
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Stefan Assmann <sassmann@redhat.com>, linux-pci@vger.kernel.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Krzysztof Halasa <khc@pm.waw.pl>, Don Dutile <ddutile@redhat.com>,
       kaneshige.kenji@jp.fujitsu.com
Subject: Re: [PATCH] change PCI nomenclature according to PCI-SIG
Message-ID: <20091130081147.274c8af0@jbarnes-piketon>
In-Reply-To: <4B126EEB.1040908@garzik.org>
References: <4B110F79.8080405@redhat.com>
	<4B111ADC.9020800@garzik.org>
	<4B123A34.5090509@redhat.com>
	<4B126EEB.1040908@garzik.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1323
Lines: 28

On Sun, 29 Nov 2009 07:54:03 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> Next, IMO, you don't have any idea how maintainers will react to this 
> patch, because you CC'd so few of them.  People who perform tree-wide 
> changes should take the time to CC __every__ relevant maintainer.  If 
> you are changing somebody's code, you should always let them know
> about it, and give them an opportunity to review the change. 
> scripts/get_maintainer.pl can help with this.
> 
> So, while the PCI maintainer might agree with the nomenclature
> change, he is not the most qualified person to state that your
> changes have no effect on drivers/edac/ppc4xx_edac.c, for example.

Honestly I'm not thrilled about it either.  Given the large
downside of making many oustanding diffs conflict, I'm wary of these
sorts of changes in general.  I suggested to Stefan that he just put
together one big patch to minimize that pain, but I didn't expect
something so huge (I was thinking it would be mainly limited to PCI
related files).

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/