Subject: Re: [PATCH] drivers/block/floppy.c: stylistic cleanups
From: Joe Perches <joe@perches.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
       David Miller <davem@davemloft.net>, LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20091201173635.GB2688@joi.lan>
References: <1259001504.16503.79.camel@Joe-Laptop.home>
	 <20091123.104130.117837098.davem@davemloft.net>
	 <1259528449.29779.194.camel@Joe-Laptop.home>
	 <20091129.165557.84377714.davem@davemloft.net>
	 <20091130092837.4998f961@nehalam>
	 <1259640820.13592.37.camel@Joe-Laptop.home> <20091201173635.GB2688@joi.lan>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 01 Dec 2009 09:46:25 -0800
Message-ID: <1259689585.21388.32.camel@Joe-Laptop.home>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1415
Lines: 46

On Tue, 2009-12-01 at 18:36 +0100, Marcin Slusarz wrote: 
> On Mon, Nov 30, 2009 at 08:13:40PM -0800, Joe Perches wrote:
> > +#define CALL(x)		do { if ((x) == -EINTR) return -EINTR; } while (0)
> > +#define ECALL(x)	do { if ((ret = (x))) return ret; } while (0)
> > +#define _WAIT(x, i)	CALL(ret = wait_til_done((x), i))
> > +#define WAIT(x)		_WAIT((x), interruptible)
> > +#define IWAIT(x)	_WAIT((x), 1)
> 
> why not remove these macros too? (probably in a seperate patch)
> macros which hide "return" are very annoying...

Hence the "still ugly".  I agree these aren't good.

> > +#define LOCK_FDC(drive, interruptible)	    \
> > +	if (lock_fdc(drive, interruptible)) \
> > +		return -EINTR;
> 
> another annoying macro

True. 
  
> > +	if (UNIT(current_drive) < 0) {
> > +		reset_fdc();
> > +		return;
> > +	}
> >  }
> 
> unneeded return

> >  	 * installing the new fdutils package */
> > -	if (cmd == CDROMEJECT ||	/* CD-ROM eject */
> > -	    cmd == 0x6470 /* SunOS floppy eject */ ) {
> > +	if (cmd == CDROMEJECT || cmd == 0x6470) {
> 
> please add descriptive constant

Patches are apparently welcomed by Stephen.
Don't wait for me, I'll catch up.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/