Date: Wed, 2 Dec 2009 11:09:28 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Xiaotian Feng <dfeng@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
       Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
       "H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev_put
Message-ID: <20091202100928.GE22654@elte.hu>
References: <1259291762-17735-1-git-send-email-dfeng@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1259291762-17735-1-git-send-email-dfeng@redhat.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 763
Lines: 23


* Xiaotian Feng <dfeng@redhat.com> wrote:

> pci_get_device increments reference count to the found pci device, 
> that should be decremented using pci_dev_put.

> +++ b/arch/x86/kernel/reboot_fixups_32.c
> @@ -80,6 +80,7 @@ void mach_reboot_fixups(void)
>  			continue;
>  
>  		cur->reboot_fixup(dev);
> +		pci_dev_put(dev);

Does this matter in practice? We are about to reboot. (but if it's 
cleaner to do it like this or if there's some real bug fixed by this 
then please spell it out in the changelog.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/