Date: Wed, 2 Dec 2009 12:03:26 +0100
From: Daniel Mack <daniel@caiaq.de>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Pierre Ossman <pierre@ossman.eu>, linux-mmc@vger.kernel.org,
       linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
       stable@kernel.org
Subject: Re: [PATCH] mmc: pxamci: call mmc_remove_host() before freeing
 resources
Message-ID: <20091202110326.GZ14091@buzzloop.caiaq.de>
References: <1259687838-31722-1-git-send-email-daniel@caiaq.de>
 <f17812d70912011650h48a6c391s426ffc8b4b653fc8@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f17812d70912011650h48a6c391s426ffc8b4b653fc8@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1156
Lines: 34

On Wed, Dec 02, 2009 at 08:50:44AM +0800, Eric Miao wrote:
> On Wed, Dec 2, 2009 at 1:17 AM, Daniel Mack <daniel@caiaq.de> wrote:
> > mmc_remove_host() will cause the mmc core to switch off the bus power by
> > eventually calling pxamci_set_ios(). This function uses the regulator or
> > the GPIO which have been freed already.
> >
> > This causes the following Oops on module unload.
> >

[...]

> >
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> > Reported-by: Sven Neumann <s.neumann@raumfeld.com>
> > Cc: Pierre Ossman <pierre@ossman.eu>
> > Cc: Eric Miao <eric.y.miao@gmail.com>
> > Cc: linux-mmc@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: stable@kernel.org
> > ---
> > ?drivers/mmc/host/pxamci.c | ? ?4 ++--
> 
> Looks like a correct fix to me.
> 
> Acked-by: Eric Miao <eric.y.miao@gmail.com>

Would be good to still get this into .32 - who will take care of picking
this?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/