Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754445AbZLBOWJ (ORCPT ); Wed, 2 Dec 2009 09:22:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753357AbZLBOWI (ORCPT ); Wed, 2 Dec 2009 09:22:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57447 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbZLBOWI (ORCPT ); Wed, 2 Dec 2009 09:22:08 -0500 Date: Wed, 2 Dec 2009 15:15:33 +0100 From: Oleg Nesterov To: Veaceslav Falico Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Al Viro , Miloslav Trmac , James Morris , Alan Cox , Ingo Molnar , Peter Zijlstra , Andrew Morton , Balbir Singh , Alexey Dobriyan , Heiko Carstens , Renaud Lottiaux , Louis Rilling , David Howells Subject: Re: [PATCH 4/4] copy_signal cleanup: clean tty_audit_fork() Message-ID: <20091202141533.GC791@redhat.com> References: <20091201221346.GD10052@darkmag.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091201221346.GD10052@darkmag.usersys.redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 33 On 12/01, Veaceslav Falico wrote: > > Remove unneeded initialization in tty_audit_fork(). > > Signed-off-by: Veaceslav Falico > --- > > diff --git a/drivers/char/tty_audit.c b/drivers/char/tty_audit.c > index ac16fbe..283a15b 100644 > --- a/drivers/char/tty_audit.c > +++ b/drivers/char/tty_audit.c > @@ -148,7 +148,6 @@ void tty_audit_fork(struct signal_struct *sig) > spin_lock_irq(¤t->sighand->siglock); > sig->audit_tty = current->signal->audit_tty; > spin_unlock_irq(¤t->sighand->siglock); > - sig->tty_audit_buf = NULL; > } OK, but given that this function is "far" from copy_signal() path and it is not inline, perhaps it makes sense to add the comment which explains *sig must be zeroed, and the only caller is copy_signal(). Hmm. Off-topic, but why do we take ->siglock? ->audit_tty is boolean, afaics ->siglock buys nothing. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/