Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754664AbZLBPDL (ORCPT ); Wed, 2 Dec 2009 10:03:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754220AbZLBPDK (ORCPT ); Wed, 2 Dec 2009 10:03:10 -0500 Received: from qw-out-2122.google.com ([74.125.92.25]:61940 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbZLBPDJ convert rfc822-to-8bit (ORCPT ); Wed, 2 Dec 2009 10:03:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=i0ja4Qn9ggwh7X/4UWA/uXq0YayQFEhHVSl1zRmCgmbcGvKvG32C+vgIBJFUq9ZHaC sN8oUFVrntCpKKUG3oqRr8XM56CpTZTWbh8dhL400YkSlmhoC8BOmwMiz3IDHYEhMyqJ DDH7+EWaRqfS6keX9o6LxB5oIj3WeutKHGtLE= MIME-Version: 1.0 In-Reply-To: <20091202110326.GZ14091@buzzloop.caiaq.de> References: <1259687838-31722-1-git-send-email-daniel@caiaq.de> <20091202110326.GZ14091@buzzloop.caiaq.de> From: Eric Miao Date: Wed, 2 Dec 2009 23:02:55 +0800 Message-ID: Subject: Re: [PATCH] mmc: pxamci: call mmc_remove_host() before freeing resources To: Daniel Mack Cc: Pierre Ossman , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 38 On Wed, Dec 2, 2009 at 7:03 PM, Daniel Mack wrote: > On Wed, Dec 02, 2009 at 08:50:44AM +0800, Eric Miao wrote: >> On Wed, Dec 2, 2009 at 1:17 AM, Daniel Mack wrote: >> > mmc_remove_host() will cause the mmc core to switch off the bus power by >> > eventually calling pxamci_set_ios(). This function uses the regulator or >> > the GPIO which have been freed already. >> > >> > This causes the following Oops on module unload. >> > > > [...] > >> > >> > Signed-off-by: Daniel Mack >> > Reported-by: Sven Neumann >> > Cc: Pierre Ossman >> > Cc: Eric Miao >> > Cc: linux-mmc@vger.kernel.org >> > Cc: linux-arm-kernel@lists.infradead.org >> > Cc: stable@kernel.org >> > --- >> >  drivers/mmc/host/pxamci.c |    4 ++-- >> >> Looks like a correct fix to me. >> >> Acked-by: Eric Miao > > Would be good to still get this into .32 - who will take care of picking > this? > I'll send a pull request, and see if Russell will be happy to send another one in such a short time :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/