Message-ID: <4B169B1B.8010007@zytor.com>
Date: Wed, 02 Dec 2009 08:51:39 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: Xiaotian Feng <dfeng@redhat.com>, x86@kernel.org,
       linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
       Ingo Molnar <mingo@redhat.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev_put
References: <1259291762-17735-1-git-send-email-dfeng@redhat.com> <20091202100928.GE22654@elte.hu>
In-Reply-To: <20091202100928.GE22654@elte.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1088
Lines: 33

On 12/02/2009 02:09 AM, Ingo Molnar wrote:
> 
> * Xiaotian Feng <dfeng@redhat.com> wrote:
> 
>> pci_get_device increments reference count to the found pci device, 
>> that should be decremented using pci_dev_put.
> 
>> +++ b/arch/x86/kernel/reboot_fixups_32.c
>> @@ -80,6 +80,7 @@ void mach_reboot_fixups(void)
>>  			continue;
>>  
>>  		cur->reboot_fixup(dev);
>> +		pci_dev_put(dev);
> 
> Does this matter in practice? We are about to reboot. (but if it's 
> cleaner to do it like this or if there's some real bug fixed by this 
> then please spell it out in the changelog.)
> 

Even if it doesn't actually matter, doing things cleanly makes it easier
to handle failure scenarios, possibly that are discovered in the future.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/