Date: Wed, 2 Dec 2009 18:14:22 +0100
From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Xiaotian Feng <dfeng@redhat.com>, x86@kernel.org,
       linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
       Ingo Molnar <mingo@redhat.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev_put
Message-ID: <20091202171422.GB28061@elte.hu>
References: <1259291762-17735-1-git-send-email-dfeng@redhat.com>
 <20091202100928.GE22654@elte.hu>
 <4B169B1B.8010007@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B169B1B.8010007@zytor.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1182
Lines: 35


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 12/02/2009 02:09 AM, Ingo Molnar wrote:
> > 
> > * Xiaotian Feng <dfeng@redhat.com> wrote:
> > 
> >> pci_get_device increments reference count to the found pci device, 
> >> that should be decremented using pci_dev_put.
> > 
> >> +++ b/arch/x86/kernel/reboot_fixups_32.c
> >> @@ -80,6 +80,7 @@ void mach_reboot_fixups(void)
> >>  			continue;
> >>  
> >>  		cur->reboot_fixup(dev);
> >> +		pci_dev_put(dev);
> > 
> > Does this matter in practice? We are about to reboot. (but if it's 
> > cleaner to do it like this or if there's some real bug fixed by this 
> > then please spell it out in the changelog.)
> > 
> 
> Even if it doesn't actually matter, doing things cleanly makes it 
> easier to handle failure scenarios, possibly that are discovered in 
> the future.

certainly - but it would be nice to know whether there's any other 
reason for this but cleanliness/consistency.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/