Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755539AbZLBThU (ORCPT ); Wed, 2 Dec 2009 14:37:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752866AbZLBThT (ORCPT ); Wed, 2 Dec 2009 14:37:19 -0500 Received: from gateway-1237.mvista.com ([206.112.117.35]:52664 "HELO imap.sh.mvista.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1755311AbZLBThS (ORCPT ); Wed, 2 Dec 2009 14:37:18 -0500 Message-ID: <4B16C233.6020808@ru.mvista.com> Date: Wed, 02 Dec 2009 22:38:27 +0300 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: pancho horrillo Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Fix a bug on appledisplay.c regarding signedness References: <20091202191942.GA7362@pancho.name> <20091202193104.GB7362@pancho.name> In-Reply-To: <20091202193104.GB7362@pancho.name> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 30 Hello. pancho horrillo wrote: > Please, review and push the patch, if you deem it adequate. > Thanks a bunch! > Signed-off-by: pancho horrillo > diff -purN a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c > --- a/drivers/usb/misc/appledisplay.c 2009-11-10 01:32:31.000000000 +0100 > +++ b/drivers/usb/misc/appledisplay.c 2009-12-02 20:05:00.000000000 +0100 > @@ -72,8 +72,8 @@ struct appledisplay { > struct usb_device *udev; /* usb device */ > struct urb *urb; /* usb request block */ > struct backlight_device *bd; /* backlight device */ > - char *urbdata; /* interrupt URB data buffer */ > - char *msgdata; /* control message data buffer */ > + uint8_t *urbdata; /* interrupt URB data buffer */ > + uint8_t *msgdata; /* control message data buffer */ That 'uint8_t' is for userspace, use 'u8' instead. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/