Date: Wed, 2 Dec 2009 21:48:53 +0100
From: Antonio Ospite <ospite@studenti.unina.it>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Richard Purdie <rpurdie@rpsys.net>, Liam Girdwood <lrg@slimlogic.co.uk>,
       Daniel Ribeiro <drwyrm@gmail.com>, linux-kernel@vger.kernel.org,
       linux-arm-kernel@lists.infradead.org, openezx-devel@lists.openezx.org
Subject: Re: [PATCH] leds: Add LED class driver for regulator driven LEDs.
Message-Id: <20091202214853.d97b860c.ospite@studenti.unina.it>
In-Reply-To: <20091202204026.GA18311@rakim.wolfsonmicro.main>
References: <1259775625-25973-1-git-send-email-ospite@studenti.unina.it>
	<20091202180658.GA12292@rakim.wolfsonmicro.main>
	<20091202212521.500f7a46.ospite@studenti.unina.it>
	<20091202204026.GA18311@rakim.wolfsonmicro.main>
Mime-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg="PGP-SHA1";
 boundary="Signature=_Wed__2_Dec_2009_21_48_53_+0100_lJTsaa1SG.Bc4z=D"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2729
Lines: 79

--Signature=_Wed__2_Dec_2009_21_48_53_+0100_lJTsaa1SG.Bc4z=D
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, 2 Dec 2009 20:40:26 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> On Wed, Dec 02, 2009 at 09:25:21PM +0100, Antonio Ospite wrote:
> > Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>=20
> > > There's no need to do this since the regulator API matches consumers
> > > based on struct device as well as name so you can have as many LEDs as
> > > you like all using the same supply name mapping to different regulato=
rs.
>=20
> > I need some more explanation here, I am currently using the driver with
> > this code:
>=20
> > +/* VVIB: Vibrator on A780, A1200, A910, E6, E2 */
> > +static struct regulator_consumer_supply pcap_regulator_VVIB_consumers
> > [] =3D {
> > +	{ .dev_name =3D "leds-regulator", .supply =3D "vibrator", },
>=20
> So you're instantiating the device with .id set to -1 (as your code
> below shows), meaning there's only one leds-regulator in the system and
> there's no need to number them.  If you had more than one of them then
> you'd number them and then have something like:
>=20
> 	{ .dev_name =3D "leds-regulator.0", supply =3D "vled" },
> 	{ .dev_name =3D "leds-regulator.1", supply =3D "vled" },
>=20
> when setting up the supplies.
>

Ok, the .id in .dev_name is what I was missing.

> > If I set the .supply value fixed, how can I assign different
> > regulators to different leds? Should I use the address to the platform
> > device (a780_vibrator in this case) for .dev when defining the
> > regulator in the first place?
>=20
> There is no need to use the .dev field, that is kept to avoid build
> breakage transitioning to dev_name.

Now everything is clear.

Thanks,
   Antonio

--=20
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

--Signature=_Wed__2_Dec_2009_21_48_53_+0100_lJTsaa1SG.Bc4z=D
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAksW0rUACgkQ5xr2akVTsAFA8wCeM0lOZK+JVZwpNT8PaPdK/7Z6
M+QAn0elN2DC2xixTSCm4NlCQrEkIs71
=W0NG
-----END PGP SIGNATURE-----

--Signature=_Wed__2_Dec_2009_21_48_53_+0100_lJTsaa1SG.Bc4z=D--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/