Subject: Re: [patch]  f83f9ac causes tasks running at MAX_PRIO
From: Mike Galbraith <efault@gmx.de>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@elte.hu>,
       LKML <linux-kernel@vger.kernel.org>,
       Steven Rostedt <rostedt@goodmis.org>,
       Thomas Gleixner <tglx@linutronix.de>
In-Reply-To: <4B17138D.3040003@bigpond.net.au>
References: <1259501027.6268.9.camel@marge.simson.net>
	 <1259754383.4003.610.camel@laptop>
	 <1259758150.6167.8.camel@marge.simson.net>
	 <4B17138D.3040003@bigpond.net.au>
Content-Type: text/plain
Date: Thu, 03 Dec 2009 02:44:27 +0100
Message-Id: <1259804667.7691.19.camel@marge.simson.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1240
Lines: 26

On Thu, 2009-12-03 at 11:25 +1000, Peter Williams wrote:
> On 02/12/09 22:49, Mike Galbraith wrote:
> > Hysterical reasons?  That might have been a doorstop conversion kit for
> > O(1), but boots fine with CFS, and prio 40 tasks are history.
> 
> In my (not so) humble opinion, there is still a lot of unnecessary cruft 
> in sched.c that should have been removed as the final (clean up) stage 
> of implementing CFS (i.e. stuff that was needed for O(1) but no longer 
> serves a useful purpose).  I know that the extra overhead of this code 
> is probably inconsequential (and the compiler may even optimize some of 
> it away) but it looks untidy and makes the code harder to understand.
> 
> Recent patches that I've submitted were intended as a start to removing 
> some of this cruft and I had intended to send more patches after they 
> were accepted.  I figured that it was better to do it as a number of 
> small changes rather than one big one.  Should I continue?

Certainly.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/