Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755657AbZLCD6v (ORCPT ); Wed, 2 Dec 2009 22:58:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753506AbZLCD6u (ORCPT ); Wed, 2 Dec 2009 22:58:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33579 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479AbZLCD6t (ORCPT ); Wed, 2 Dec 2009 22:58:49 -0500 Message-ID: <4B1737E2.6010502@redhat.com> Date: Wed, 02 Dec 2009 23:00:34 -0500 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Mathieu Desnoyers CC: Steven Rostedt , akpm@linux-foundation.org, Ingo Molnar , mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, randy.dunlap@oracle.com, wcohen@redhat.com, fweisbec@gmail.com, tglx@linutronix.de, jbaron@redhat.com, linux-tip-commits@vger.kernel.org, Christoph Hellwig Subject: Re: trace/events: DECLARE vs DEFINE semantic References: <20091202144334.GA30359@elte.hu> <1259765735.12870.42.camel@gandalf.stny.rr.com> <20091202162715.GB9710@Krystal> <1259773888.12870.61.camel@gandalf.stny.rr.com> <20091202180633.GF9710@Krystal> <1259777987.12870.70.camel@gandalf.stny.rr.com> <20091202190135.GA23316@Krystal> <1259781578.12870.78.camel@gandalf.stny.rr.com> <4B16EC06.6010706@redhat.com> <1259794005.12870.102.camel@gandalf.stny.rr.com> <20091202231019.GB14770@Krystal> In-Reply-To: <20091202231019.GB14770@Krystal> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 56 Mathieu Desnoyers wrote: > In addition, I wonder if we should rename "CREATE_TRACE_POINTS" to > something more suitable while we are here ? Basically, it will affect > all TRACE_CLASS/TRACE_CLASS_EVENT/TRACE_EVENT from headers included > after it's defined. Agreed, CREATE_TRACE_POINTS is a bit irritating thing :-( For example, if we call tracepoints defined in same-header on several different files, we need to check other people have already defined CREATE_TRACE_POINTS on another file, because CREATE_TRACE_POINTS must be used once for each header... So, how about introducing a c file which is only for defining tracepoints for kernel parts ? or defining tracepoints in kernel at the beginning of kernel/tracepoint.c ? (and don't touch tracepoints in modules) e.g. @kernel/tracepoint.c ... #define CREATE_TRACE_POINTS #include #include ... @kernel/sched.c ... #include /* Just include events header */ ... @fs/ext4/super.c (no change, since it can be module) ... #define CREATE_TRACE_POINTS #include ... Hmm? Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/