Date: Wed, 2 Dec 2009 20:20:12 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: Michael Breuer <mbreuer@majjas.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Bug (minor): microcode_intel.c applies updates to hyperthreaded
 cores
Message-ID: <20091202202012.0c7b6768@infradead.org>
In-Reply-To: <4B17393B.7000304@majjas.com>
References: <4B17393B.7000304@majjas.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 29

On Wed, 02 Dec 2009 23:06:19 -0500
Michael Breuer <mbreuer@majjas.com> wrote:

> According to spec, microcode should only be applied to actual cores.
> As things are currently structured, looks like the fix would be in
> microcode_core.c. I don't think changing the loop to look for cores
> vs. cpu's would affect anything adversely, but honestly am not
> familiar enough with this code or other cpu types to be sure.
> 

isn't this

for each (logical) cpu
   check microcode version of the cpu
   if too old, apply microcode

the 2nd pair of a hyperthreading pair will never see the 'too old' case
happen...


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/