DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=nzx6YmwseBSy1p1rshLtqekw0kaOqX6CCMgnqssHTNdRHapKRZhxXyHvumi1d0aDy1
         Vd7sWGGUV0Lm3EYhZ4IwRuEc2sIiF47neKbw9Kvg3/DFDJPn8LzDZemzXNbZrfy8963e
         L9wZDt8qjmhEEULjBtDg3Y0svCd5yFEGcDNgo=
Date: Wed, 2 Dec 2009 23:15:07 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: liu pf <kernelfans@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Should we use preempt_disable() in sleep_on_common()?
Message-ID: <20091203071507.GJ9121@core.coreip.homeip.net>
References: <563a732e0912022249y1e831c6cv7f2d5d376b8a5f63@mail.gmail.com> <20091202230746.611f7fc5@infradead.org> <20091203071244.GI9121@core.coreip.homeip.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091203071244.GI9121@core.coreip.homeip.net>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 964
Lines: 29

On Wed, Dec 02, 2009 at 11:12:44PM -0800, Dmitry Torokhov wrote:
> On Wed, Dec 02, 2009 at 11:07:46PM -0800, Arjan van de Ven wrote:
> > On Thu, 3 Dec 2009 14:49:14 +0800
> > liu pf <kernelfans@gmail.com> wrote:
> > 
> > > Hi:
> > > 
> > > I am puzzled with the following scenario. Could anyone enlighten me?
> > 
> > 
> > sleep_on family of APIs is very racy and just cannot be used correctly;
> > I'm not surprised that there's a preempt race in it, but trust me, it's
> > not the biggest race... never ever use these APIs!!!
> > 
> > 
> 
> BTW, why do we still have them? I checked couple and they don't seem to
> be used...
> 

Ah, my bad, I now see interruptible_sleep_on used all over drivers/char...

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/