Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754488AbZLCIsd (ORCPT ); Thu, 3 Dec 2009 03:48:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752567AbZLCIsc (ORCPT ); Thu, 3 Dec 2009 03:48:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1055 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbZLCIsb (ORCPT ); Thu, 3 Dec 2009 03:48:31 -0500 Date: Thu, 3 Dec 2009 03:48:28 -0500 From: Amerigo Wang To: linux-kernel@vger.kernel.org Cc: Eric Paris , linux-security-module@vger.kernel.org, akpm@linux-foundation.org, Amerigo Wang , James Morris Message-Id: <20091203085127.4370.1737.sendpatchset@localhost.localdomain> Subject: [Patch] selinux: remove a useless return Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 27 The last return is unreachable, remove the 'return' in default, let it fall through. Signed-off-by: WANG Cong Cc: James Morris Cc: Eric Paris --- diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c index b5407f1..718823d 100644 --- a/security/selinux/ss/mls.c +++ b/security/selinux/ss/mls.c @@ -542,7 +542,7 @@ int mls_compute_sid(struct context *scontext, /* Use the process effective MLS attributes. */ return mls_context_cpy_low(newcontext, scontext); default: - return -EINVAL; + /* Fallthrough */ } return -EINVAL; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/