Date: Thu, 3 Dec 2009 11:13:29 +0000
From: Alan Cox <alan@linux.intel.com>
To: Cong Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       Greg Kroah-Hartman <gregkh@suse.de>, Joe Peterson <joe@skyrush.com>
Subject: Re: [Patch] tty: move a definition out of switch block
Message-ID: <20091203111329.3558ea39@linux.intel.com>
In-Reply-To: <4B177878.2090002@redhat.com>
References: <20091201075744.4456.48125.sendpatchset@localhost.localdomain>
	<20091201154412.4002a0d8@linux.intel.com>
	<4B177878.2090002@redhat.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 593
Lines: 20

> jumps to its first label at a first glance. I know in this case
> the code is _not_ wrong, but again, it's not good for reading.

So this is just your personal preference ? That seems like pointless
churn, especially given that many other people consider putting the
variables there is better than

	case foo:
	{
		Blah blah
	}
	}
}

in switches
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/