Message-ID: <4B17D9D1.7010402@redhat.com>
Date: Thu, 03 Dec 2009 10:31:29 -0500
From: Masami Hiramatsu <mhiramat@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4
MIME-Version: 1.0
To: rostedt@goodmis.org
CC: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
       akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
       mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
       randy.dunlap@oracle.com, wcohen@redhat.com, fweisbec@gmail.com,
       tglx@linutronix.de, jbaron@redhat.com,
       linux-tip-commits@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: trace/events: DECLARE vs DEFINE semantic
References: <20091202144334.GA30359@elte.hu>	 <1259765735.12870.42.camel@gandalf.stny.rr.com>	 <20091202162715.GB9710@Krystal>	 <1259773888.12870.61.camel@gandalf.stny.rr.com>	 <20091202180633.GF9710@Krystal>	 <1259777987.12870.70.camel@gandalf.stny.rr.com>	 <20091202190135.GA23316@Krystal>	 <1259781578.12870.78.camel@gandalf.stny.rr.com>	 <4B16EC06.6010706@redhat.com>	 <1259794005.12870.102.camel@gandalf.stny.rr.com>	 <20091202231019.GB14770@Krystal>  <4B1737E2.6010502@redhat.com>	 <1259813228.12870.108.camel@gandalf.stny.rr.com>	 <4B17C25A.8090703@redhat.com> <1259848493.12870.114.camel@gandalf.stny.rr.com>
In-Reply-To: <1259848493.12870.114.camel@gandalf.stny.rr.com>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2396
Lines: 78

Steven Rostedt wrote:
> On Thu, 2009-12-03 at 08:51 -0500, Masami Hiramatsu wrote:
> 
>>> Basically, we should have a:
>>>
>>> kernel/sched_trace.c that includes the include/trace/events/sched.h and
>>> does the define.
>>>
>>> And the same goes for other trace points.
>>
>> Hmm, I'd rather like to move it into kernel/events/ or something new
>> sub directory, since those files will have just two lines (define and
>> include).
> 
> I'm fine with a kernel/events dir.
> 
>>
>>>> e.g.
>>>>
>>>> @kernel/tracepoint.c
>>>>   ...
>>>>   #define CREATE_TRACE_POINTS
>>>>   #include<trace/events/sched.h>
>>>>   #include<trace/events/...>
>>>
>>> We could do this for all that is defined in the include/trace/events.
>>>
>>>>   ...
>>>>
>>>> @kernel/sched.c
>>>>   ...
>>>>   #include<trace/events/sched.h>	/* Just include events header */
>>>>   ...
>>>>
>>>> @fs/ext4/super.c (no change, since it can be module)
>>>>   ...
>>>>   #define CREATE_TRACE_POINTS
>>>>   #include<trace/events/ext4.h>
>>>
>>> Perhaps we should move out anything in include/trace/events that is also
>>> a module into its sub system?
>>
>> Would you mean putting those headers in sub-system's directory?
>> (e.g. fs/ext4/)
>> In that case, a problem will happen when user want to hook those
>> tracepoint from their module, because it is hard to find those
>> local headers.
> 
> Why? Modules usually do have their own headers in their sub system.

Module's local headers usually uses only from itself. Other modules
may not touch it. However, AFAIK, event definitions must be referred
by event consumer which is another module. IOW, those local headers
will not be included in kernel-headers/kernel-devel package :-(

> OK, if a module keeps their headers global (include/linux) then sure
> they can keep their tracepoint header in include/trace/events. But I
> still think that the module CREATE_TRACE_POINTS code should be kept with
> the module code itself (but in a small separate file).

Yeah, that's reasonable. :-)

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/