Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbZLDHGI (ORCPT ); Fri, 4 Dec 2009 02:06:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751927AbZLDHGH (ORCPT ); Fri, 4 Dec 2009 02:06:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38837 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbZLDHGG (ORCPT ); Fri, 4 Dec 2009 02:06:06 -0500 Message-ID: <4B18B4CA.5060602@redhat.com> Date: Fri, 04 Dec 2009 15:05:46 +0800 From: Danny Feng User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Justin Mattock CC: lenb@kernel.org, ming.m.lin@intel.com, robert.moore@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPICA: don't cond_resched() when irq_disabled or in_atomic References: <1259900760-6424-1-git-send-email-dfeng@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2364 Lines: 62 On 12/04/2009 02:50 PM, Justin Mattock wrote: > On Thu, Dec 3, 2009 at 8:26 PM, Xiaotian Feng wrote: >> commit 8bd108d adds preemption point after each opcode parse, then >> a sleeping function called from invalid context bug was founded >> during suspend/resume stage. this was fixed in commit abe1dfa by >> don't cond_resched when irq_disabled. But recent commit 138d156 changes >> the behaviour to don't cond_resched when in_atomic. This makes the >> sleeping function called from invalid context bug happen again, which >> is reported in http://lkml.org/lkml/2009/12/1/371. >> >> The fix is to cond_sched() only when preemptible, which means not in >> irq_disabled or in_atomic. >> >> Reported-and-bisected-by: Larry Finger >> Signed-off-by: Xiaotian Feng >> --- >> include/acpi/platform/aclinux.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h >> index 9d7febd..5b415ee 100644 >> --- a/include/acpi/platform/aclinux.h >> +++ b/include/acpi/platform/aclinux.h >> @@ -152,7 +152,7 @@ static inline void *acpi_os_acquire_object(acpi_cache_t * cache) >> #include >> #define ACPI_PREEMPTION_POINT() \ >> do { \ >> - if (!in_atomic_preempt_off()) \ >> + if (preemptible()) \ >> cond_resched(); \ >> } while (0) >> >> -- >> 1.6.5.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > > looks good > kernel compiled without any issues, > echo mem> /sys/power/state > reported no warning message. > > Also if you don't mind add: > Reported-and-bisected-by: Justin P. Mattock > Sure, sorry for I had missed thread for http://bugzilla.kernel.org/show_bug.cgi?id=14483 > Id like to get some kind of credit for this b*tch. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/