Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755865AbZLDJtz (ORCPT ); Fri, 4 Dec 2009 04:49:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752401AbZLDJty (ORCPT ); Fri, 4 Dec 2009 04:49:54 -0500 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:46563 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754732AbZLDJtx (ORCPT ); Fri, 4 Dec 2009 04:49:53 -0500 Date: Fri, 4 Dec 2009 15:19:32 +0530 From: "Aneesh Kumar K.V" To: "Yin, Kangkai" Cc: "linux-ext4@vger.kernel.org" , linux-kernel@vger.kernel.org, Andrew Morton , Jan Kara Subject: Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable. Message-ID: <20091204094932.GC4272@skywalker.linux.vnet.ibm.com> References: <20091204031735.GN19635@kai-debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091204031735.GN19635@kai-debian> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2467 Lines: 71 On Fri, Dec 04, 2009 at 11:17:35AM +0800, Yin, Kangkai wrote: > Hi, > > Re-send since seems my mail was dropped by vger, because of my wrong > envelope_from.. > > ---- > I was trying to enable the jbd debug option, and found that jbd-debug > in debugfs is read-only, shouldn't that be writable? > > Found in both .31 stable kernel and .32 one. > > Thanks, > Kangkai > > From 492ec0453ca3458c68deaa6e308ca01acc0eca1f Mon Sep 17 00:00:00 2001 > From: Yin Kangkai > Date: Thu, 3 Dec 2009 18:01:38 +0800 > Subject: [PATCH] jbd: jbd-debug and jbd2-debug should be writable. > > jbd-debug and jbd2-debug is currently read-only (S_IRUGO), which is not > correct. Make it writable so that we can start debuging. > > Signed-off-by: Yin Kangkai Reviewed-by: Aneesh Kumar K.V > --- > fs/jbd/journal.c | 2 +- > fs/jbd2/journal.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c > index 4160afa..bd224ee 100644 > --- a/fs/jbd/journal.c > +++ b/fs/jbd/journal.c > @@ -1913,7 +1913,7 @@ static void __init jbd_create_debugfs_entry(void) > { > jbd_debugfs_dir = debugfs_create_dir("jbd", NULL); > if (jbd_debugfs_dir) > - jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO, > + jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO | S_IWUSR, > jbd_debugfs_dir, > &journal_enable_debug); > } > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index fed8538..3c41c5a 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -2103,7 +2103,8 @@ static void __init jbd2_create_debugfs_entry(void) > { > jbd2_debugfs_dir = debugfs_create_dir("jbd2", NULL); > if (jbd2_debugfs_dir) > - jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME, S_IRUGO, > + jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME, > + S_IRUGO | S_IWUSR, > jbd2_debugfs_dir, > &jbd2_journal_enable_debug); > } > -- > 1.6.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/