Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756016AbZLDLPz (ORCPT ); Fri, 4 Dec 2009 06:15:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754873AbZLDLPy (ORCPT ); Fri, 4 Dec 2009 06:15:54 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:35986 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753560AbZLDLPx (ORCPT ); Fri, 4 Dec 2009 06:15:53 -0500 Date: Fri, 4 Dec 2009 12:15:59 +0100 From: Sascha Hauer To: Amit Kucheria Cc: List Linux Kernel , "David S. Miller" , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, valentin.longchamp@epfl.ch, daniel@caiaq.de, grant.likely@secretlab.ca, Dinh.Nguyen@freescale.com, r.herring@freescale.com Subject: Re: [RFC][PATCH 07/10] fec: Add LAN8700 phy support Message-ID: <20091204111559.GM15126@pengutronix.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Entwicklungszentrum Nord - Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Impressum: Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Peiner Strasse 6-8, 31137 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-5555 Inhaber: Dipl.-Ing. Robert Schwebel X-Message-Flag: See Message Headers for Impressum X-Uptime: 12:14:22 up 53 days, 3 min, 61 users, load average: 0.04, 1.00, 1.95 User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2222 Lines: 71 On Fri, Dec 04, 2009 at 04:47:07AM +0200, Amit Kucheria wrote: > The i.MX51 babbage board has a FEC ethernet controller with this phy. I already saw patches for proper phylib support for the fec driver. Maybe we should reactivate them rather than adding another phy to this driver. Sascha > > Signed-off-by: Amit Kucheria > Cc: David S. Miller > Cc: netdev@vger.kernel.org > --- > drivers/net/fec.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/fec.c b/drivers/net/fec.c > index 9a8743d..5d0d332 100644 > --- a/drivers/net/fec.c > +++ b/drivers/net/fec.c > @@ -1128,6 +1128,26 @@ static phy_info_t phy_info_dp83848= { > }, > }; > > +static phy_info_t phy_info_lan8700 = { > + 0x0007C0C, > + "LAN8700", > + (const phy_cmd_t []) { /* config */ > + { mk_mii_read(MII_REG_CR), mii_parse_cr }, > + { mk_mii_read(MII_REG_ANAR), mii_parse_anar }, > + { mk_mii_end, } > + }, > + (const phy_cmd_t []) { /* startup */ > + { mk_mii_write(MII_REG_CR, 0x1200), NULL }, /* autonegotiate */ > + { mk_mii_read(MII_REG_SR), mii_parse_sr }, > + { mk_mii_end, } > + }, > + (const phy_cmd_t []) { /* act_int */ > + { mk_mii_end, } > + }, > + (const phy_cmd_t []) { /* shutdown */ > + { mk_mii_end, } > + }, > +}; > /* ------------------------------------------------------------------------- */ > > static phy_info_t const * const phy_info[] = { > @@ -1137,6 +1157,7 @@ static phy_info_t const * const phy_info[] = { > &phy_info_am79c874, > &phy_info_ks8721bl, > &phy_info_dp83848, > + &phy_info_lan8700, > NULL > }; > > -- > 1.6.3.3 > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/