Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756128AbZLDL2I (ORCPT ); Fri, 4 Dec 2009 06:28:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755604AbZLDL2H (ORCPT ); Fri, 4 Dec 2009 06:28:07 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:39372 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755489AbZLDL2F (ORCPT ); Fri, 4 Dec 2009 06:28:05 -0500 Date: Fri, 4 Dec 2009 12:28:11 +0100 From: Sascha Hauer To: Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= Cc: Amit Kucheria , List Linux Kernel , Dinh.Nguyen@freescale.com, grant.likely@secretlab.ca, r.herring@freescale.com, linux-arm-kernel@lists.infradead.org, daniel@caiaq.de, valentin.longchamp@epfl.ch Subject: Re: [RFC][PATCH 04/10] arm: mxc: Fix Drive Strength Field in the IOMUX controller Message-ID: <20091204112811.GN15126@pengutronix.de> References: <20091204093824.GB10910@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20091204093824.GB10910@pengutronix.de> X-Sent-From: Pengutronix Entwicklungszentrum Nord - Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Impressum: Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Peiner Strasse 6-8, 31137 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-5555 Inhaber: Dipl.-Ing. Robert Schwebel X-Message-Flag: See Message Headers for Impressum X-Uptime: 12:24:16 up 53 days, 13 min, 61 users, load average: 5.87, 2.37, 1.90 User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1901 Lines: 49 On Fri, Dec 04, 2009 at 10:38:24AM +0100, Uwe Kleine-K?nig wrote: > Hello, > > On Fri, Dec 04, 2009 at 04:47:04AM +0200, Amit Kucheria wrote: > > i.MX51 defines 4 values: > > > > 00: Low Drive Strength > > 01: Medium Drive Strength > > 10: High Drive Strength > > 11: Max Drive Strength > > > > Signed-off-by: Amit Kucheria > > --- > > arch/arm/plat-mxc/include/mach/iomux-v3.h | 8 +++++--- > > 1 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/plat-mxc/include/mach/iomux-v3.h b/arch/arm/plat-mxc/include/mach/iomux-v3.h > > index a0fa402..8c351d6 100644 > > --- a/arch/arm/plat-mxc/include/mach/iomux-v3.h > > +++ b/arch/arm/plat-mxc/include/mach/iomux-v3.h > > @@ -81,11 +81,13 @@ struct pad_desc { > > > > #define PAD_CTL_ODE (1 << 3) > > > > -#define PAD_CTL_DSE_STANDARD (0 << 1) > > -#define PAD_CTL_DSE_HIGH (1 << 1) > > -#define PAD_CTL_DSE_MAX (2 << 1) > > +#define PAD_CTL_DSE_LOW (0 << 1) > > +#define PAD_CTL_DSE_MED (1 << 1) > > +#define PAD_CTL_DSE_HIGH (2 << 1) > > +#define PAD_CTL_DSE_MAX (3 << 1) > Does the new values work on other SOCs having iomux-v3, too? They should work. on i.MX35 (2 << 1) and (3 << 1) are both max driving strength. It's only that the names change, but these macros are unused currently, so this shouldn't hurt. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/