Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932388AbZLDRrQ (ORCPT ); Fri, 4 Dec 2009 12:47:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932300AbZLDRrQ (ORCPT ); Fri, 4 Dec 2009 12:47:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34848 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbZLDRrP (ORCPT ); Fri, 4 Dec 2009 12:47:15 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1244854869-2563-1-git-send-email-vapier@gentoo.org> References: <1244854869-2563-1-git-send-email-vapier@gentoo.org> To: uClinux development list Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, Jie Zhang , Greg Ungerer , uclinux-dist-devel@blackfin.uclinux.org, David McCullough Subject: Re: [uClinux-dev] [PATCH/RFC] FDPIC: add hook for arches to customize program header parsing Date: Fri, 04 Dec 2009 17:44:57 +0000 Message-ID: <14959.1259948697@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 21 Mike Frysinger wrote: > The Blackfin port has custom program header flags/addresses for > automatically loading regions into the dedicated on-chip SRAM. So add a > hook for ports to leverage. Now that I've ACK'd this, I feel I'm going to have to NAK it. I'm not against the general concept, but: > + do_munmap(mm, *maddr, phdr->p_memsz + *disp); There needs to be a mapping covering the SRAM region for the purposes of the debugger. Do you have a chardev covering the SRAM device? Perhaps through MTD? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/