Message-ID: <4B1990CB.5090702@canonical.com>
Date: Fri, 04 Dec 2009 14:44:27 -0800
From: John Johansen <john.johansen@canonical.com>
Organization: Canonical
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: David Howells <dhowells@redhat.com>
CC: Eric Paris <eparis@redhat.com>, linux-security-module@vger.kernel.org,
       linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org,
       akpm@linux-foundation.org, gyang@blackfin.uclinux.org
Subject: Re: [PATCH] security: do not check mmap_min_addr on nommu systems
References: <20091203194300.8491.22110.stgit@paris.rdu.redhat.com> <32275.1259923944@redhat.com>
In-Reply-To: <32275.1259923944@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 824
Lines: 24

David Howells wrote:
> Eric Paris <eparis@redhat.com> wrote:
> 
>> +/* sec_flags for security_file_mmap */
>> +/* Only check the address portion */
>> +#define SECURITY_MMAP_ADDR_ONLY	0x01
>> +/* Do not do the address checks */
>> +#define SECURITY_MMAP_NOT_ADDR	0x02
> 
> I'm still not happy with the names assigned to these constants.  
> 
> Can we call them:
> 
> #define SECURITY_MMAP_ADDR_CHECK_ONLY	0x01
> #define SECURITY_MMAP_SKIP_ADDR_CHECK	0x02
> 
> and then discard the comments?
I do like these suggested names a little better.  Either way I am happy
with the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/