Message-ID: <4B19A92A.5030804@analog.com>
Date: Sat, 5 Dec 2009 08:28:26 +0800
From: Jie Zhang <jie.zhang@analog.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091203 Lightning/1.0pre Shredder/3.0
MIME-Version: 1.0
To: David Howells <dhowells@redhat.com>
CC: uClinux development list <uclinux-dev@uclinux.org>,
       linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
       uclinux-dist-devel@blackfin.uclinux.org,
       David McCullough <davidm@snapgear.com>
Subject: Re: [uClinux-dev] [PATCH/RFC] FDPIC: add hook for arches to customize
 program header parsing
References: <1244854869-2563-1-git-send-email-vapier@gentoo.org> <14959.1259948697@redhat.com>
In-Reply-To: <14959.1259948697@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1079
Lines: 32

On 12/05/2009 01:44 AM, David Howells wrote:
> Mike Frysinger<vapier@gentoo.org>  wrote:
>
>> The Blackfin port has custom program header flags/addresses for
>> automatically loading regions into the dedicated on-chip SRAM.  So add a
>> hook for ports to leverage.
>
> Now that I've ACK'd this, I feel I'm going to have to NAK it.  I'm not against
> the general concept, but:
>
>> +		do_munmap(mm, *maddr, phdr->p_memsz + *disp);
>
> There needs to be a mapping covering the SRAM region for the purposes of the

Our GDB is still lack of the feature to debug applications using SRAM. 
So this part of code was not got exercised. So if we remove this line, 
can this patch got merged?

> debugger.  Do you have a chardev covering the SRAM device?  Perhaps through
> MTD?
>
Sorry, I don't know the answer to these two questions.


Jie


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/